rohityadavcloud commented on code in PR #6924:
URL: https://github.com/apache/cloudstack/pull/6924#discussion_r1098398377
##########
plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAMLUtils.java:
##########
@@ -286,7 +287,10 @@ public static void setupSamlUserCookies(final
LoginCmdResponse loginResponse, fi
resp.addCookie(new Cookie("account",
URLEncoder.encode(loginResponse.getAccount(), HttpUtils.UTF_8)));
resp.addCookie(new Cookie("isSAML", URLEncoder.encode("true",
HttpUtils.UTF_8)));
resp.addCookie(new Cookie("twoFaEnabled",
URLEncoder.encode(loginResponse.is2FAenabled(), HttpUtils.UTF_8)));
- resp.addCookie(new Cookie("twoFaProvider",
URLEncoder.encode(loginResponse.getProviderFor2FA(), HttpUtils.UTF_8)));
+ String providerFor2FA = loginResponse.getProviderFor2FA();
+ if (StringUtils.isNoneEmpty(providerFor2FA)) {
Review Comment:
@harikrishna-patnala do you mean `if (!<condition>)`, the missing !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
