DaanHoogland commented on code in PR #7634:
URL: https://github.com/apache/cloudstack/pull/7634#discussion_r1231033161
##########
server/src/main/java/com/cloud/network/NetworkModelImpl.java:
##########
@@ -593,7 +593,11 @@ public List<? extends Nic> getNics(long vmId) {
@Override
public String getNextAvailableMacAddressInNetwork(long networkId) throws
InsufficientAddressCapacityException {
NetworkVO network = _networksDao.findById(networkId);
- String mac = _networksDao.getNextAvailableMacAddress(networkId,
MACIdentifier.value());
+ Integer zoneIdentifyer = MACIdentifier.value();
Review Comment:
I do wonder if
```
final SequenceFetcher fetch = SequenceFetcher.getInstance();
long seq = fetch.getNextSequence(Long.class, _tgMacAddress,
networkConfigId);
```
reliably generates a unique mac though. Even after a restart I mean. I
haven´t found the persisting of a sequence yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
