DaanHoogland commented on code in PR #7634:
URL: https://github.com/apache/cloudstack/pull/7634#discussion_r1231087792
##########
server/src/main/java/com/cloud/network/NetworkModelImpl.java:
##########
@@ -593,7 +593,11 @@ public List<? extends Nic> getNics(long vmId) {
@Override
public String getNextAvailableMacAddressInNetwork(long networkId) throws
InsufficientAddressCapacityException {
NetworkVO network = _networksDao.findById(networkId);
- String mac = _networksDao.getNextAvailableMacAddress(networkId,
MACIdentifier.value());
+ Integer zoneIdentifyer = MACIdentifier.value();
Review Comment:
I cleanedup the code a little more @weizhouapache . I think we have a more
or less determanistic way of generating now. Le me see if I can create some
tests to come with this ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
