wido commented on code in PR #7580:
URL: https://github.com/apache/cloudstack/pull/7580#discussion_r1253083338
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/VifDriverBase.java:
##########
@@ -41,6 +43,11 @@ public void configure(Map<String, Object> params) throws
ConfigurationException
_pifs = (Map<String, String>)params.get("libvirt.host.pifs");
}
+ protected String getControlCidr(String defaultValue, Map<String, Object>
params) {
Review Comment:
Almost looks good. You aren't using the params variable anywhere, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
