DaanHoogland commented on PR #8253: URL: https://github.com/apache/cloudstack/pull/8253#issuecomment-1820743323
> @DaanHoogland yep, I think it makes sense to make this field visible if the user enters Protocol Number equal to 1 (ICMP) > > however, personally, I find it a bit weird to enter the protocol number directly instead of choosing the already predefined ICMP, don't you think so? :p maybe, but there are 255 protocol numbers possible and I have no idea if all of those use port ranges or maybe some of them use service/qos or some other combination. I don't think we can cater for everything. Also I do not know if your change is affending someone's intended use. Given those remarks, it is fine by me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
