weizhouapache commented on PR #8253: URL: https://github.com/apache/cloudstack/pull/8253#issuecomment-1829730810
> Since we have "ICMP" as a dedicated menu item (next to Protocol Number) - I think this PR makes sense - hide other ICMP fields if "ICMP" is not specifically the chosen protocol. +1 ideally these 2 fields should be visible when protocol number is 1 (ICMP) or 58 (IPv6-ICMP), it requires some other changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
