slavkap commented on code in PR #8353:
URL: https://github.com/apache/cloudstack/pull/8353#discussion_r1425282812
##########
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##########
@@ -923,42 +924,47 @@ public PrimaryDataStoreInfo
createPool(CreateStoragePoolCmd cmd) throws Resource
return (PrimaryDataStoreInfo)_dataStoreMgr.getDataStore(store.getId(),
DataStoreRole.Primary);
}
- private Map<String,String> extractUriParamsAsMap(String url){
+ protected Map<String,String> extractUriParamsAsMap(String url, boolean
managed) {
Map<String,String> uriParams = new HashMap<>();
UriUtils.UriInfo uriInfo = UriUtils.getUriInfo(url);
Review Comment:
@shwstppr, it will fail here if the URL is not valid. Also, the Storpool
plugin doesn't use the managed tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
