slavkap commented on code in PR #8353:
URL: https://github.com/apache/cloudstack/pull/8353#discussion_r1425327476
##########
server/src/main/java/com/cloud/storage/StorageManagerImpl.java:
##########
@@ -808,7 +809,7 @@ protected String createLocalStoragePoolName(Host host,
StoragePoolInfo storagePo
@Override
public PrimaryDataStoreInfo createPool(CreateStoragePoolCmd cmd) throws
ResourceInUseException, IllegalArgumentException, UnknownHostException,
ResourceUnavailableException {
String providerName = cmd.getStorageProviderName();
- Map<String,String> uriParams = extractUriParamsAsMap(cmd.getUrl());
+ Map<String,String> uriParams = extractUriParamsAsMap(cmd.getUrl(),
cmd.isManaged());
Review Comment:
@shwstppr, sorry github doesn't allow you to comment on lines without any
changes. On lines 825 and 897 there will be null pointer if the uriParams is
empty.
```
825 ScopeType scopeType =
uriParams.get("scheme").toString().equals("file") ? ScopeType.HOST :
ScopeType.CLUSTER;
897 if (params.get("scheme").toString().equals("file"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
