DaanHoogland commented on PR #8337: URL: https://github.com/apache/cloudstack/pull/8337#issuecomment-1862712934
> > code looks good @winterhazel . @JoaoJandre , did you test the new functionality exclusively or poke around for regressions as well? > > @DaanHoogland sorry for not explaining my tests. > > 1. Create a new account through the UI and then lock it through the UI; > > 2. Try to log in with it, the UI displays a message saying that the account was locked; > > 3. Unlock the account through the UI; > > 4. Log in. That is no problem, just making sure we know what the status is. These I had tested as well, without explaining in https://github.com/apache/cloudstack/pull/8337#pullrequestreview-1777122461 (/me equaly guilty) My point is that the scope has increased and we now also need to test some other dialog (pluralis majestatis used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
