weizhouapache commented on code in PR #8489:
URL: https://github.com/apache/cloudstack/pull/8489#discussion_r1450410064
##########
ui/src/views/compute/KubernetesServiceTab.vue:
##########
@@ -403,8 +403,8 @@ export default {
ips = ips.filter(x => x.issourcenat)
this.publicIpAddress = ips.length > 0 ? ips[0] : null
}
- }).catch(error => {
- this.$notifyError(error)
+ }).catch(() => {
+ this.publicIpAddress = null
Review Comment:
> How do you know that @MejdiB is using shared networks with domain scope in
their CKS clusters? Were you able to reproduce the error reported on #7681?
Yes, I am able to reproduce the issue in advanced zone with SG.
>
> In any case, shouldn't we test if the user is trying to list the public
IPs of a shared network with domain scope and not call the API in this case?
It's better than ignoring any error that might happen on the API call.
>
this PR is the simplest way.
The better solution might be (1) listNetworks; (2) skip if network type is
Shared.
but it did not work in my testing ,may require some investigation.
> Also, a description of the tests done would be great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
