shwstppr commented on code in PR #9206:
URL: https://github.com/apache/cloudstack/pull/9206#discussion_r1634228124
##########
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java:
##########
@@ -532,11 +532,6 @@ public void handleTemplateSync(DataStore store) {
s_logger.info("Skip downloading template " +
tmplt.getUniqueName() + " since no url is specified.");
continue;
}
- // if this is private template, skip sync to a new
image store
- if (isSkipTemplateStoreDownload(tmplt, zoneId)) {
Review Comment:
I feel the log here is probably wrong otherwise the last condition in the
method should take care of the case where the template is private but it needs
to be downloaded to a new zone? Or do we download all templates to all stores
of the zones?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
