weizhouapache commented on code in PR #9206:
URL: https://github.com/apache/cloudstack/pull/9206#discussion_r1635877732
##########
engine/storage/image/src/main/java/org/apache/cloudstack/storage/image/TemplateServiceImpl.java:
##########
@@ -532,11 +532,6 @@ public void handleTemplateSync(DataStore store) {
s_logger.info("Skip downloading template " +
tmplt.getUniqueName() + " since no url is specified.");
continue;
}
- // if this is private template, skip sync to a new
image store
- if (isSkipTemplateStoreDownload(tmplt, zoneId)) {
Review Comment:
the method `isSkipTemplateStoreDownload` was added in your pr #7485
the original code snippet was introduced many years ago, only
public/featured/system templates are copied.
```
if (!tmplt.isPublicTemplate() &&
!tmplt.isFeatured() && tmplt.getTemplateType() != TemplateType.SYSTEM) {
s_logger.info("Skip sync downloading private
template " + tmplt.getUniqueName() + " to a new image store");
continue;
}
```
in my opinion, all the templates/isos should be copied to new image store.
this needs some discussion
(this is why I created this pr as draft. `isSkipTemplateStoreDownload` can
be removed later in this pr)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
