weizhouapache commented on code in PR #9410:
URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1686331368
##########
engine/schema/src/main/resources/META-INF/db/schema-41910to42000.sql:
##########
@@ -154,3 +154,47 @@ WHERE
-- Quota inject tariff result into subsequent ones
CALL `cloud_usage`.`IDEMPOTENT_ADD_COLUMN`('cloud_usage.quota_tariff',
'position', 'bigint(20) NOT NULL DEFAULT 1 COMMENT "Position in the execution
sequence for tariffs of the same type"');
+
+-- Add tables for AS Numbers and range
+CREATE TABLE `cloud`.`as_number_range` (
+ `id` bigint unsigned NOT NULL AUTO_INCREMENT,
+ `uuid` varchar(40) DEFAULT NULL,
+ `data_center_id` bigint unsigned NOT NULL COMMENT 'zone that it belongs
to',
+ `start_as_number` bigint unsigned DEFAULT NULL COMMENT 'start AS number of
the range',
+ `end_as_number` bigint unsigned DEFAULT NULL COMMENT 'end AS number of the
range',
Review Comment:
```suggestion
`start_as_number` bigint unsigned NOT NULL COMMENT 'start AS number of
the range',
`end_as_number` bigint unsigned NOT NULL COMMENT 'end AS number of the
range',
```
##########
api/src/main/java/com/cloud/dc/BGPService.java:
##########
@@ -0,0 +1,32 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.dc;
+
+import com.cloud.utils.Pair;
+import org.apache.cloudstack.api.command.user.bgp.ListASNumbersCmd;
+
+import java.util.List;
+
+public interface BGPService {
Review Comment:
maybe better move to another package instead of ` com.cloud.dc` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
