weizhouapache commented on code in PR #9410:
URL: https://github.com/apache/cloudstack/pull/9410#discussion_r1686530796
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/KubernetesClusterManagerImpl.java:
##########
@@ -839,7 +848,7 @@ private void
validateManagedKubernetesClusterCreateParameters(final CreateKubern
}
private Network getKubernetesClusterNetworkIfMissing(final String
clusterName, final DataCenter zone, final Account owner, final int
controlNodesCount,
- final int nodesCount, final String
externalLoadBalancerIpAddress, final Long networkId) throws
CloudRuntimeException {
+ final int nodesCount, final String
externalLoadBalancerIpAddress, final Long networkId, final Long asNumber)
throws CloudRuntimeException {
Review Comment:
@nvazquez @Pearl1594
asnumber is a parameter of network, not CKS cluster.
if we decide to accept `asnumber` as a CKS parameter, should we also accept
other network parameters like network offering, network cidr, network service
providers ?
In my point of view, if user want to create CKS cluster on networks with
non-default network offering, they should create the network in advanced, then
create CKS cluster on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
