DaanHoogland commented on code in PR #9426:
URL: https://github.com/apache/cloudstack/pull/9426#discussion_r1686340539
##########
test/integration/smoke/test_purge_expunged_vms.py:
##########
@@ -349,15 +353,18 @@ def test_05_purge_expunged_vm_service_offering(self):
@skipTestIf("hypervisorIsSimulator")
@attr(tags=["advanced"], required_hardware="true")
def test_06_purge_expunged_vm_background_task(self):
- purge_task_delay = 60
+ purge_task_delay = 120
self.changeConfiguration('expunged.resources.purge.enabled', 'true')
self.changeConfiguration('expunged.resources.purge.delay',
purge_task_delay)
+ self.changeConfiguration('expunged.resources.purge.interval',
int(purge_task_delay/2))
self.changeConfiguration('expunged.resources.purge.keep.past.days', 1)
if len(self.staticConfigurations) > 0:
self.restartAllManagementServers()
- wait = 2 * purge_task_delay
- logging.info("Waiting for 2x%d = %d seconds for background task to
execute" % (purge_task_delay, wait))
+ wait_multiple = 2
+ wait = wait_multiple * purge_task_delay
+ logging.info("Waiting for %dx%d = %d seconds for background task to
execute" % (wait_multiple, purge_task_delay, wait))
Review Comment:
```suggestion
logging.info(f"Waiting for {wait_multiple}x{purge_task_delay} =
{wait} seconds for background task to execute")
```
##########
test/integration/smoke/test_purge_expunged_vms.py:
##########
@@ -273,6 +273,7 @@ def restartAllManagementServers(self):
return False
self.debug("Restarting all management server")
for idx, server_ip in enumerate(server_ips):
+ self.debug("Restarting management server #%d with IP %s" % (idx,
server_ip))
Review Comment:
```suggestion
self.debug(f"Restarting management server #{idx} with IP
{server_ip}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
