JoaoJandre commented on code in PR #9270:
URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1739311322
##########
server/src/main/java/org/apache/cloudstack/snapshot/SnapshotHelper.java:
##########
@@ -264,4 +264,12 @@ protected Set<Long>
getSnapshotIdsOnlyInPrimaryStorage(long volumeId) {
return snapshotIdsOnlyInPrimaryStorage;
}
+
+ public SnapshotInfo convertSnapshotIfNeeded(SnapshotInfo snapshotInfo) {
+ if (snapshotInfo.getParent() == null) {
Review Comment:
@slavkap In the future, we could copy the snapshot chain to the other
secondary storage. However, further changes would need to be done, for example,
we would need to rebase the snapshots with their new parents (otherwise, we run
into the exception you mentioned above), that means changing more processes on
the SSVM, also we would need to add `qemu-img` to the System VM template.
Since the current implementation is working, and this PR is already pretty
big, I would rather introduce this feature as is and optimize it in the future
if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
