slavkap commented on code in PR #9270:
URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1737964988
##########
server/src/main/java/org/apache/cloudstack/snapshot/SnapshotHelper.java:
##########
@@ -264,4 +264,12 @@ protected Set<Long>
getSnapshotIdsOnlyInPrimaryStorage(long volumeId) {
return snapshotIdsOnlyInPrimaryStorage;
}
+
+ public SnapshotInfo convertSnapshotIfNeeded(SnapshotInfo snapshotInfo) {
+ if (snapshotInfo.getParent() == null) {
Review Comment:
@JoaoJandre, all works good! But isn't it better to transfer the parent IDs
to the copied snapshots? My point is that when you copy the snapshot it
increases the time if there is a need for the snapshot to be converted, and
this could be avoided only in cases when you need to create a template/volume
from the snapshot on the second zone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
