weizhouapache commented on code in PR #10221:
URL: https://github.com/apache/cloudstack/pull/10221#discussion_r1926727174
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -2796,8 +2800,18 @@ public int calculateCpuShares(VirtualMachineTO vmTO) {
if (hostCpuMaxCapacity > 0) {
Review Comment:
@phsm
I quickly checked the codebase
it looks like for cgroup V1, the hostCpuMaxCapacity is 0.
https://github.com/apache/cloudstack/blob/81e052cfebf5bcdb09e1922393a1753eb6707dae/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java#L3773-L3777
so this pr might not work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
