weizhouapache commented on code in PR #10221:
URL: https://github.com/apache/cloudstack/pull/10221#discussion_r1926754161
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -2796,8 +2800,18 @@ public int calculateCpuShares(VirtualMachineTO vmTO) {
if (hostCpuMaxCapacity > 0) {
Review Comment:
thanks for the explanation, it makese sense.
I think more changes are needed.
the checks will not be performed for cgroup V1, because hostCpuMaxCapacity
is 0, therefore line 2801
```
if (hostCpuMaxCapacity > 0) {
```
it looks like the checks need to be added in `else`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
