bernardodemarco opened a new pull request, #10279:
URL: https://github.com/apache/cloudstack/pull/10279

   ### Description
   
   Currently, when changing the `Decimal`, `Number` and `Range` global settings 
values through the UI, CloudStack does not validate if the inserted values are 
numeric. Additionally, when letters are entered in the inputs, a message 
indicating that the setting value was successfully updated is returned to the 
operators, which does not effectively happen.
   
   Therefore, this PR proposes to verify the values that are entered in those 
input fields. If non-numeric values are inserted, they will be ignored. 
Furthermore, it is still possible to use special keys, such as `Ctrl` and 
`Alt`, in order to make use of keyboard shortcuts.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [X] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   - [ ] test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   ### Screenshots (if appropriate):
   
   ### How Has This Been Tested?
   
   - Verified that in `Decimal` and `Range` global settings it is only possible 
to enter digits and the period (`.`) character.
   - Verified that in `Number` global settings it is only possible to enter 
digits.
   - Verified that in `Decimal`, `Number` and `Range` global settings it is 
still possible to make use of keyboard shortcuts with special keys.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to