DaanHoogland commented on PR #10279: URL: https://github.com/apache/cloudstack/pull/10279#issuecomment-2615801078
> > clgtm and tested in QA, one minor nit: the period is not localised (Dutch uses comma ','. and this is not allowed in decimal fields like overprovisioning. > > @DaanHoogland, thanks for testing. > > Yes, Portuguese also uses comma. However, the backend has a validation that does not accept it, for example: > > ```shell > (acs-all-in-one) 🙉 > update configuration name="cpu.overprovisioning.factor" value="2,55" > 🙈 Error: (HTTP 431, error code 4350) Value [2,55] is not a valid [class java.lang.Float]. > ``` yes, no issue with this PR for sure, just a remark/not to self to maybe deal with in the future (or not) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
