weizhouapache commented on PR #10140: URL: https://github.com/apache/cloudstack/pull/10140#issuecomment-2808502266
overall lgtm note about the `setDeviceId` - for vm created from template, the data volume uses diskofferingId , so deviceId=1 is correct - for vm created from ISO, the root volume uses diskofferingId , deviceId should be 0 I think. - for vm created with multiple data disks, it uses `datadiskofferinglist`, but deviceId of volumes are not set in dataDiskOfferingInfo. is `deviceId` important for this feature ? cc @abh1sar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
