abh1sar commented on PR #10140:
URL: https://github.com/apache/cloudstack/pull/10140#issuecomment-2814485921
> About the deviceId of datadiskoffering
>
> ```
> dataDiskOfferingInfo.setDeviceId(1L);
> ```
>
> should it be 0 if the vm is created from ISO ? this is not a valid
question if we do not support backup actions for vm from ISO.
For VM from ISOs createVirtualMachineFromScratch is called where deviceId
remains null in rootDiskOfferingInfo and in allocateRawVolume the deviceId for
volume is set to 0L.
```
if (deviceId != null) {
vol.setDeviceId(deviceId);
} else if (type.equals(Type.ROOT)) {
vol.setDeviceId(0l);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
