Re: [PR] Instance lease: Allow deployment of instances with lease duration and leaseexpiry action [cloudstack]

[via GitHub]

sudo87 commented on code in PR #10560:
URL: https://github.com/apache/cloudstack/pull/10560#discussion_r2108171801


##########
api/src/main/java/org/apache/cloudstack/api/ApiConstants.java:
##########
@@ -269,7 +269,10 @@ public class ApiConstants {
     public static final String INTERNAL_DNS2 = "internaldns2";
     public static final String INTERNET_PROTOCOL = "internetprotocol";
     public static final String INTERVAL_TYPE = "intervaltype";
-    public static final String LOCATION_TYPE = "locationtype";
+    public static final String INSTANCE_LEASE_DURATION = "leaseduration";
+    public static final String INSTANCE_LEASE_ENABLED = "instanceleaseenabled";

Review Comment:
   instanceleasenabled is used in listCapabilities response and to keep it 
consistent with other available keys, "instance" is prepended to it:
   
   
![image](https://github.com/user-attachments/assets/b492366f-166e-448b-b1b7-22632673c577)
   
   Whereas param names are related to instance and compute offering both, 
adding "instance" doesn't make sense.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org