sudo87 commented on code in PR #10560:
URL: https://github.com/apache/cloudstack/pull/10560#discussion_r2108166233
##########
server/src/main/java/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java:
##########
@@ -176,6 +177,11 @@ public ServiceOfferingResponse
newServiceOfferingResponse(ServiceOfferingJoinVO
}
}
+ if (VMLeaseManager.InstanceLeaseEnabled.value() &&
offering.getLeaseDuration() != null && offering.getLeaseDuration() > 0L) {
Review Comment:
Its an optional feature and when disabled, will have no functional and
visual change for VM/offering. If disabled, no trace of lease info should be
shown in API response.
On (re)/enable, offerings with existing lease will become active. However
instances using compute offering with lease, will not get automatically inherit
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
