jbampton commented on code in PR #11017:
URL: https://github.com/apache/cloudstack/pull/11017#discussion_r2159189318


##########
.yamllint.yml:
##########


Review Comment:
   This `.yamllint.yml` config file should go in the `.github/linters` folder.
   
   https://github.com/apache/cloudstack/tree/main/.github/linters
   
   Better to keep the repository root organized and uncluttered. 
   
   See the open issue. Thanks



##########
.pre-commit-config.yaml:
##########
@@ -95,3 +95,11 @@ repos:
         args: [--config=.github/linters/.markdown-lint.yml]
         types: [markdown]
         files: \.(md|mdown|markdown)$
+  - repo: https://github.com/adrienverge/yamllint
+    rev: v1.35.1
+    hooks:
+      - id: yamllint
+        name: run yamllint
+        description: check YAML files with yamllint
+        args: [--config-file=.yamllint.yml]
+        files: \.(yaml|yml)$

Review Comment:
   ```suggestion
           files: \.ya?ml$
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to