sureshanaparti commented on code in PR #10458:
URL: https://github.com/apache/cloudstack/pull/10458#discussion_r2222730983
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -605,14 +610,14 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
defaultVPCOffProviders.remove(Service.Lb);
offering =
_configMgr.createNetworkOffering(NetworkOffering.DefaultIsolatedNetworkOfferingForVpcNetworksNoLB,
"Offering for Isolated VPC networks with Source
Nat service enabled and LB service disabled", TrafficType.Guest, null, false,
Availability.Optional,
- null, defaultVPCOffProviders, true,
Network.GuestType.Isolated, false, null, false, null, false, false, null,
false, null, true, true, false, false, null, null, null,true, null, null,
false);
+ null, defaultVPCOffProviders, true,
Network.GuestType.Isolated, false, null, false, null, false, false, null,
false, null, true, true, false, false, false,null, null, null,true, null, null,
false);
}
//#7 - isolated offering with source nat disabled
if
(_networkOfferingDao.findByUniqueName(NetworkOffering.DefaultIsolatedNetworkOffering)
== null) {
offering =
_configMgr.createNetworkOffering(NetworkOffering.DefaultIsolatedNetworkOffering,
"Offering for Isolated networks with no Source Nat service",
TrafficType.Guest, null, true,
Availability.Optional, null, defaultIsolatedNetworkOfferingProviders, true,
Network.GuestType.Isolated, false, null,
- true, null, true, false, null, false, null, true,
false, false, false, null, null, null, true, null, null, false);
+ true, null, true, false, null, false, null, true,
false, false, false, false,null, null, null, true, null, null, false);
Review Comment:
```suggestion
true, null, true, false, null, false, null,
true, false, false, false, false, null, null, null, true, null, null, false);
```
```suggestion
true, null, true, false, null, false, null,
true, false, false, false, false,null, null, null, true, null, null, false);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
