sureshanaparti commented on code in PR #10458:
URL: https://github.com/apache/cloudstack/pull/10458#discussion_r2222747751
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java:
##########
@@ -3296,6 +3323,14 @@ public boolean shutdownNetworkElementsAndResources(final
ReservationContext cont
}
}
}
+ if (network.getVpcId() != null) {
+ _vpcMgr.reconfigStaticNatForVpcVr(network.getVpcId());
+ try {
+ _vpcMgr.applyStaticRouteForVpcVpnIfNeeded(network.getVpcId(),
true);
+ } catch (ResourceUnavailableException e) {
+ logger.error("Unable to apply static routes for vpc " +
network.getVpcId() + " due to " + e.getMessage());
+ }
+ }
Review Comment:
can move this code ^^^ to a method, same code repeated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
