JoaoJandre opened a new pull request, #11448:
URL: https://github.com/apache/cloudstack/pull/11448

   ### Description
   
   This PR fixes the snapshot physical size listing. Since #7873, the snapshot 
physical size has only been fetched from the secondary storage. This has two 
issues:
   1. It is possible for the snapshot to be on the primary storage, and thus 
these snapshots always return size 0.
   2. Up until #9270, at least in KVM, every snapshot that was copied to 
secondary storage also had a reference to the primary storage. As the 
SnapshotObject has the ID for the primary storage reference, when searching for 
the reference to get the size, we search for a reference that is in the storage 
with role Image, but the ID of a primary storage; thus, no reference is 
returned.
   
   This PR fixes this behavior. Fixes #11442
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   - [ ] build/CI
   - [ ] test (unit or integration test code)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   ### Screenshots (if appropriate):
   
   ### How Has This Been Tested?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to