rajujith commented on code in PR #7857:
URL: https://github.com/apache/cloudstack/pull/7857#discussion_r2333369874
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -1453,33 +1453,33 @@ private void validateVmForHostMigration(VirtualMachine
vm) {
final Account caller = getCaller();
if (!_accountMgr.isRootAdmin(caller.getId())) {
if (logger.isDebugEnabled()) {
- logger.debug("Caller is not a root admin, permission denied to
migrate the VM");
+ logger.debug("Caller is not a root admin, permission denied to
migrate the Instance");
}
- throw new PermissionDeniedException("No permission to migrate VM,
Only Root Admin can migrate a VM!");
+ throw new PermissionDeniedException("No permission to migrate
instance, Only Root Admin can migrate an instance!");
}
if (vm == null) {
- throw new InvalidParameterValueException("Unable to find the VM
with given id");
+ throw new InvalidParameterValueException("Unable to find the
Instance with given id");
}
if (vm.getState() != State.Running) {
if (logger.isDebugEnabled()) {
- logger.debug("VM is not running, cannot migrate the vm" + vm);
+ logger.debug("Instance is not running, cannot migrate the
Instance" + vm);
}
- final InvalidParameterValueException ex = new
InvalidParameterValueException("VM is not Running, cannot " + "migrate the vm
with specified id");
+ final InvalidParameterValueException ex = new
InvalidParameterValueException("Instance is not Running, cannot " + "migrate
the instance with specified id");
ex.addProxyObject(vm.getUuid(), "vmId");
throw ex;
}
if
(!LIVE_MIGRATION_SUPPORTING_HYPERVISORS.contains(vm.getHypervisorType())) {
if (logger.isDebugEnabled()) {
- logger.debug(vm + " is not
XenServer/VMware/KVM/Ovm/Hyperv/Ovm3, cannot migrate this VM.");
+ logger.debug(vm + " is not
XenServer/VMWare/KVM/Ovm/Hyperv/Ovm3, cannot migrate this Instance.");
Review Comment:
'VMware'
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -1453,33 +1453,33 @@ private void validateVmForHostMigration(VirtualMachine
vm) {
final Account caller = getCaller();
if (!_accountMgr.isRootAdmin(caller.getId())) {
if (logger.isDebugEnabled()) {
- logger.debug("Caller is not a root admin, permission denied to
migrate the VM");
+ logger.debug("Caller is not a root admin, permission denied to
migrate the Instance");
}
- throw new PermissionDeniedException("No permission to migrate VM,
Only Root Admin can migrate a VM!");
+ throw new PermissionDeniedException("No permission to migrate
instance, Only Root Admin can migrate an instance!");
}
if (vm == null) {
- throw new InvalidParameterValueException("Unable to find the VM
with given id");
+ throw new InvalidParameterValueException("Unable to find the
Instance with given id");
}
if (vm.getState() != State.Running) {
if (logger.isDebugEnabled()) {
- logger.debug("VM is not running, cannot migrate the vm" + vm);
+ logger.debug("Instance is not running, cannot migrate the
Instance" + vm);
}
- final InvalidParameterValueException ex = new
InvalidParameterValueException("VM is not Running, cannot " + "migrate the vm
with specified id");
+ final InvalidParameterValueException ex = new
InvalidParameterValueException("Instance is not Running, cannot " + "migrate
the instance with specified id");
ex.addProxyObject(vm.getUuid(), "vmId");
throw ex;
}
if
(!LIVE_MIGRATION_SUPPORTING_HYPERVISORS.contains(vm.getHypervisorType())) {
if (logger.isDebugEnabled()) {
- logger.debug(vm + " is not
XenServer/VMware/KVM/Ovm/Hyperv/Ovm3, cannot migrate this VM.");
+ logger.debug(vm + " is not
XenServer/VMWare/KVM/Ovm/Hyperv/Ovm3, cannot migrate this Instance.");
}
- throw new InvalidParameterValueException("Unsupported Hypervisor
Type for VM migration, we support " + "XenServer/VMware/KVM/Ovm/Hyperv/Ovm3
only");
+ throw new InvalidParameterValueException("Unsupported Hypervisor
Type for instance migration, we support " +
"XenServer/VMWare/KVM/Ovm/Hyperv/Ovm3 only");
Review Comment:
'VMware'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
