DaanHoogland commented on code in PR #11649:
URL: https://github.com/apache/cloudstack/pull/11649#discussion_r2355261454
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vpn/UpdateVpnConnectionCmd.java:
##########
@@ -66,7 +66,7 @@ public long getEntityOwnerId() {
@Override
public String getEventDescription() {
- return "Updating site-to-site VPN connection id= " + id;
+ return "Updating site-to-site VPN connection id = " + id;
Review Comment:
```suggestion
return "Updating site-to-site VPN connection ID = " + id;
```
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vpn/UpdateVpnGatewayCmd.java:
##########
@@ -63,7 +63,7 @@ public long getEntityOwnerId() {
@Override
public String getEventDescription() {
- return "Update site-to-site VPN gateway id= " + id;
+ return "Update site-to-site VPN gateway id = " + id;
Review Comment:
```suggestion
return "Update site-to-site VPN gateway ID = " + id;
```
##########
engine/schema/src/main/java/com/cloud/vm/dao/UserVmDaoImpl.java:
##########
@@ -782,7 +782,7 @@ public List<Ternary<Integer, Integer, Integer>>
countVmsBySize(long dcId, int li
result.add(new Ternary<Integer, Integer,
Integer>(rs.getInt(1), rs.getInt(2), rs.getInt(3)));
}
} catch (Exception e) {
- logger.warn("Error counting vms by size for dcId= " + dcId, e);
+ logger.warn("Error counting vms by size for dcId = " + dcId, e);
Review Comment:
```suggestion
logger.warn("Error counting vms by size for Data Center ID = " +
dcId, e);
```
##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -2105,7 +2105,7 @@ private Pair<List<ProjectJoinVO>, Integer>
listProjectsInternal(ListProjectsCmd
}
if (domainId != null && !domainId.equals(caller.getDomainId())) {
- throw new PermissionDeniedException("Can't list domain id= " +
domainId + " projects; unauthorized");
+ throw new PermissionDeniedException("Can't list domain id = "
+ domainId + " projects; unauthorized");
Review Comment:
```suggestion
throw new PermissionDeniedException("Can't list domain ID =
" + domainId + " projects; unauthorized");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
