bernardodemarco commented on code in PR #11649:
URL: https://github.com/apache/cloudstack/pull/11649#discussion_r2366229976
##########
api/src/main/java/org/apache/cloudstack/api/command/user/loadbalancer/UpdateLBStickinessPolicyCmd.java:
##########
@@ -62,7 +62,7 @@ public long getEntityOwnerId() {
@Override
public String getEventDescription() {
- return "Update load balancer stickiness policy ID= " + id;
Review Comment:
Same as
https://github.com/apache/cloudstack/pull/11649#discussion_r2366229637
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vpn/UpdateVpnConnectionCmd.java:
##########
@@ -66,7 +66,7 @@ public long getEntityOwnerId() {
@Override
public String getEventDescription() {
- return "Updating site-to-site VPN connection id= " + id;
Review Comment:
Same as
https://github.com/apache/cloudstack/pull/11649#discussion_r2366229637
##########
server/src/main/java/com/cloud/api/query/QueryManagerImpl.java:
##########
@@ -2105,7 +2105,7 @@ private Pair<List<ProjectJoinVO>, Integer>
listProjectsInternal(ListProjectsCmd
}
if (domainId != null && !domainId.equals(caller.getDomainId())) {
- throw new PermissionDeniedException("Can't list domain id= " +
domainId + " projects; unauthorized");
Review Comment:
Same as
https://github.com/apache/cloudstack/pull/11649#discussion_r2366229637
##########
engine/schema/src/main/java/com/cloud/vm/dao/UserVmDaoImpl.java:
##########
@@ -782,7 +782,7 @@ public List<Ternary<Integer, Integer, Integer>>
countVmsBySize(long dcId, int li
result.add(new Ternary<Integer, Integer,
Integer>(rs.getInt(1), rs.getInt(2), rs.getInt(3)));
}
} catch (Exception e) {
- logger.warn("Error counting vms by size for dcId= " + dcId, e);
Review Comment:
Same as
https://github.com/apache/cloudstack/pull/11649#discussion_r2366229637
##########
engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java:
##########
@@ -886,7 +886,7 @@ public Long countByZoneAndStateAndHostTag(long dcId, State
state, String hostTag
return rs.getLong(1);
}
} catch (Exception e) {
- logger.warn(String.format("Error counting vms by host tag for
dcId= %s, hostTag= %s", dcId, hostTag), e);
Review Comment:
Same as
https://github.com/apache/cloudstack/pull/11649#discussion_r2366229637
##########
api/src/main/java/org/apache/cloudstack/api/command/user/vpn/UpdateVpnGatewayCmd.java:
##########
@@ -63,7 +63,7 @@ public long getEntityOwnerId() {
@Override
public String getEventDescription() {
- return "Update site-to-site VPN gateway id= " + id;
Review Comment:
Same as
https://github.com/apache/cloudstack/pull/11649#discussion_r2366229637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
