pavanaravapalli commented on code in PR #10213:
URL: https://github.com/apache/cloudstack/pull/10213#discussion_r2362170524
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3161,18 +3196,9 @@ public int compare(final DiskTO arg0, final DiskTO arg1)
{
disk.setDiscard(DiscardType.UNMAP);
}
} else {
- if (volume.getType() == Volume.Type.DATADISK &&
!(isWindowsTemplate && isUefiEnabled)) {
- disk.defFileBasedDisk(physicalDisk.getPath(), devId,
diskBusTypeData, DiskDef.DiskFmtType.QCOW2);
- } else {
- if (isSecureBoot) {
- disk.defFileBasedDisk(physicalDisk.getPath(),
devId, DiskDef.DiskFmtType.QCOW2, isWindowsTemplate);
- } else {
- disk.defFileBasedDisk(physicalDisk.getPath(),
devId, diskBusType, DiskDef.DiskFmtType.QCOW2);
- }
- }
-
+ defineDiskForDefaultPoolType(disk, volume,
isWindowsTemplate, isUefiEnabled, isSecureBoot,
Review Comment:
@shwstppr If a user forces the disk type with this template flag, will
Secure Boot still work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
