shwstppr commented on code in PR #10213:
URL: https://github.com/apache/cloudstack/pull/10213#discussion_r2366199705
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3161,18 +3196,9 @@ public int compare(final DiskTO arg0, final DiskTO arg1)
{
disk.setDiscard(DiscardType.UNMAP);
}
} else {
- if (volume.getType() == Volume.Type.DATADISK &&
!(isWindowsTemplate && isUefiEnabled)) {
- disk.defFileBasedDisk(physicalDisk.getPath(), devId,
diskBusTypeData, DiskDef.DiskFmtType.QCOW2);
- } else {
- if (isSecureBoot) {
- disk.defFileBasedDisk(physicalDisk.getPath(),
devId, DiskDef.DiskFmtType.QCOW2, isWindowsTemplate);
- } else {
- disk.defFileBasedDisk(physicalDisk.getPath(),
devId, diskBusType, DiskDef.DiskFmtType.QCOW2);
- }
- }
-
+ defineDiskForDefaultPoolType(disk, volume,
isWindowsTemplate, isUefiEnabled, isSecureBoot,
Review Comment:
@pavanaravapalli probably not for all guest OSes, but should work for newer
ones, as #9460 reports VM works fine with virtio. Also, as this is optional, it
is up to the operator to check and use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
