bernardodemarco commented on PR #10790: URL: https://github.com/apache/cloudstack/pull/10790#issuecomment-3473209075
> In this case updateConfiguration it does look like a red flag though. configurations are so ubiquitous that it might trigger all kinds of side effects. @DaanHoogland, yes, exactly... > We don’t have a nullAllowed field for configurations. What I mean is to first ignore all the current PR's changes and then change the following block of code: https://github.com/apache/cloudstack/blob/3d6cafe1936ed2403a1031cd5ad42dd205934412/server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java#L1041-L1043 To something like this: ```java if (value == null) { throw new CloudRuntimeException(String.format("A value for the [%s] configuration must be informed.", name)); } ``` With that, I believe it won't be required to change integration tests and the UI. I'll soon try to test this approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
