rg9975 commented on code in PR #11071:
URL: https://github.com/apache/cloudstack/pull/11071#discussion_r2528345475
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/MultipathSCSIAdapterBase.java:
##########
@@ -164,9 +178,10 @@ private KVMPhysicalDisk getPhysicalDisk(AddressInfo
address, KVMStoragePool pool
// validate we have a connection, if not we need to connect first.
if (!isConnected(address.getPath())) {
- if (!connectPhysicalDisk(address, pool, null)) {
- throw new CloudRuntimeException("Unable to connect to volume "
+ address.getPath());
- }
+ LOGGER.debug("Physical disk " + address.getPath() + " is not
connected, a request to connectPhysicalDisk must be made before it can be
used.");
+ } else {
+ LOGGER.debug("Physical disk " + address.getPath() + " is
connected, proceeding to get its size.");
+
Review Comment:
Updates in upcomming commit. method should return null when connection is
not yet made instead of proceeding to the sizing logic. also changed log to a
warn instead of debug since this would be an unexpected condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
