Copilot commented on code in PR #12214:
URL: https://github.com/apache/cloudstack/pull/12214#discussion_r2603151447
##########
ui/src/views/infra/zone/ZoneWizardAddResources.vue:
##########
@@ -865,6 +865,9 @@ export default {
}, {
id: 'aarch64',
description: 'ARM 64 bits (aarch64)'
+ }, {
+ id: 's390x',
+ description: 'S390X 64 bits (s390x)'
Review Comment:
Inconsistent description format. This file uses "S390X 64 bits (s390x)"
while other UI files use different formats:
- `plugins.js` uses "IBM Z/Architecture 64 bits (s390x)"
- `DeployVMFromBackup.vue` uses "IBM Z 64 bits (s390x)"
For consistency with existing patterns (e.g., "ARM 64 bits (aarch64)"),
consider using "IBM Z 64 bits (s390x)" or "IBM Z/Architecture 64 bits (s390x)"
consistently across all UI files.
```suggestion
description: 'IBM Z 64 bits (s390x)'
```
##########
ui/src/views/infra/ClusterUpdate.vue:
##########
@@ -168,6 +168,10 @@ export default {
id: 'aarch64',
description: 'ARM 64 bits (aarch64)'
})
+ typesList.push({
+ id: 's390x',
+ description: 'S390X 64 bits (s390x)'
Review Comment:
Inconsistent description format. This file uses "S390X 64 bits (s390x)"
while other UI files use different formats:
- `plugins.js` uses "IBM Z/Architecture 64 bits (s390x)"
- `DeployVMFromBackup.vue` uses "IBM Z 64 bits (s390x)"
For consistency with existing patterns (e.g., "ARM 64 bits (aarch64)"),
consider using "IBM Z 64 bits (s390x)" or "IBM Z/Architecture 64 bits (s390x)"
consistently across all UI files.
```suggestion
description: 'IBM Z 64 bits (s390x)'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
