shwstppr commented on code in PR #12214:
URL: https://github.com/apache/cloudstack/pull/12214#discussion_r2605769362
##########
plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java:
##########
@@ -865,7 +865,9 @@ private void verifyPoliticOn_(Document domainDoc) {
private void verifyFeatures(Document domainDoc) {
assertNodeExists(domainDoc, "/domain/features/pae");
assertNodeExists(domainDoc, "/domain/features/apic");
- assertNodeExists(domainDoc, "/domain/features/acpi");
+ if (!"s390x".equals(System.getProperty("os.arch"))) {
Review Comment:
```suggestion
if
(!CPU.CPUArch.s390x.getType().equalsIgnoreCase(System.getProperty("os.arch"))) {
```
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java:
##########
@@ -420,7 +420,9 @@ public String toString() {
guestDef.append("<boot dev='" + bo + "'/>\n");
}
}
- guestDef.append("<smbios mode='sysinfo'/>\n");
+ if (!(_arch != null && _arch.equals("s390x"))) {
Review Comment:
```suggestion
if (!CPU.CPUArch.s390x.getType().equalsIgnoreCase(_arch)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
