abh1sar commented on code in PR #12550:
URL: https://github.com/apache/cloudstack/pull/12550#discussion_r2746919700
##########
api/src/main/java/org/apache/cloudstack/backup/BackupManager.java:
##########
@@ -42,10 +43,11 @@ public interface BackupManager extends BackupService,
Configurable, PluggableSer
"false",
"Is backup and recovery framework enabled.", false,
ConfigKey.Scope.Zone);
- ConfigKey<String> BackupProviderPlugin = new ConfigKey<>("Advanced",
String.class,
+ ConfigKey<String> BackupProviderPlugin = new
ValidatedConfigKey<>("Advanced", String.class,
"backup.framework.provider.plugin",
"dummy",
- "The backup and recovery provider plugin.", true,
ConfigKey.Scope.Zone, BackupFrameworkEnabled.key());
+ "The backup and recovery provider plugin. Valid plugin values:
dummy, veeam, networker and nas",
+ true, ConfigKey.Scope.Zone, BackupFrameworkEnabled.key(), value ->
validateBackupProviderConfig((String)value));
Review Comment:
```suggestion
true, ConfigKey.Scope.Zone, BackupFrameworkEnabled.key(), value
-> validateBackupProviderConfig((String) value));
```
##########
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java:
##########
@@ -972,10 +972,11 @@ public BackupProvider getBackupProvider(final String
name) {
if (StringUtils.isEmpty(name)) {
throw new CloudRuntimeException("Invalid backup provider name
provided");
}
- if (!backupProvidersMap.containsKey(name)) {
+ String[] backupProviderNames = name.split(",");
Review Comment:
This is not possible now, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
