Pearl1594 commented on code in PR #12550:
URL: https://github.com/apache/cloudstack/pull/12550#discussion_r2747226256
##########
server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java:
##########
@@ -972,10 +972,11 @@ public BackupProvider getBackupProvider(final String
name) {
if (StringUtils.isEmpty(name)) {
throw new CloudRuntimeException("Invalid backup provider name
provided");
}
- if (!backupProvidersMap.containsKey(name)) {
+ String[] backupProviderNames = name.split(",");
Review Comment:
I don't think so, currently, ACS allows taking any string as input, so if we
provide a comma separated string, it would compare that with providers
supported in ACS, and would fail and report Cannot find backup provider by
name: dummy,nas (if both were set)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
