sureshanaparti commented on code in PR #12622:
URL: https://github.com/apache/cloudstack/pull/12622#discussion_r2910805177
##########
engine/schema/src/main/java/com/cloud/network/dao/NetworkVO.java:
##########
@@ -600,7 +600,9 @@ public boolean equals(Object obj) {
return true;
}
- return NetUtils.isNetworkAWithinNetworkB(cidr, that.cidr);
+ return NetUtils.isNetworkAWithinNetworkB(
+
com.cloud.utils.StringUtils.getFirstValueFromCommaSeparatedString(cidr),
+
com.cloud.utils.StringUtils.getFirstValueFromCommaSeparatedString(that.cidr));
Review Comment:
Hi @jeanvetorello Can you check this? Also, Check
_getFirstValueFromCommaSeparatedString()_ can be included in cidrToLong()
method to avoid this issue from other usages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]