winterhazel opened a new pull request, #12884: URL: https://github.com/apache/cloudstack/pull/12884
### Description This PR addresses a regression in the import of unmanaged/external VMs using a custom compute offering. As both `serviceOffering.getCpu()` and `serviceOffering.getRamSize()` return null when the offering is custom constrained/unconstrained, we need to check the amount of CPUs and memory returned by the hypervisor in case an unmanaged instance is being imported, or the `cpuNumber` and `memory` details in case the instance belongs to a remote host/is being imported from its disk. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] build/CI - [ ] test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Bug Severity - [X] BLOCKER - [ ] Critical - [ ] Major - [ ] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? Tests are still pending. The following operations need to be validated with both fixed and custom offerings: - Unmanaged KVM/VMware VM import. - KVM VM import from a remote host. - KVM VM import from an existing disk. - VMware to KVM instance conversion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
