abh1sar commented on code in PR #12884:
URL: https://github.com/apache/cloudstack/pull/12884#discussion_r2985279664
##########
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:
##########
@@ -1634,6 +1670,10 @@ protected UserVm
importUnmanagedInstanceFromVmwareToKvm(DataCenter zone, Cluster
Pair<UnmanagedInstanceTO, Boolean> sourceInstanceDetails =
getSourceVmwareUnmanagedInstance(vcenter, datacenterName, username, password,
clusterName, sourceHostName, sourceVMName);
sourceVMwareInstance = sourceInstanceDetails.first();
isClonedInstance = sourceInstanceDetails.second();
+
+ // Ensure that the configured resource limits will not be exceeded
before beggining the conversion process
Review Comment:
```suggestion
// Ensure that the configured resource limits will not be
exceeded before beginning the conversion process
```
##########
server/src/main/java/org/apache/cloudstack/vm/UnmanagedVMsManagerImpl.java:
##########
@@ -1555,6 +1559,36 @@ private UserVm
importUnmanagedInstanceFromHypervisor(DataCenter zone, Cluster cl
return userVm;
}
+ private void checkVmResourceLimitsForUnmanagedInstanceImport(Account
owner, UnmanagedInstanceTO unmanagedInstance, ServiceOfferingVO
serviceOffering, VMTemplateVO template, List<Reserver> reservations) throws
ResourceAllocationException {
+ // When importing a unmanaged instance, the amount of CPUs and memory
is obtained from the hypervisor unless powered off
Review Comment:
```suggestion
// When importing an unmanaged instance, the amount of CPUs and
memory is obtained from the hypervisor unless powered off
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
