sureshanaparti commented on code in PR #12702:
URL: https://github.com/apache/cloudstack/pull/12702#discussion_r3000113267
##########
plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/api/command/VerifyOAuthCodeAndGetUserCmd.java:
##########
@@ -58,6 +59,14 @@ public class VerifyOAuthCodeAndGetUserCmd extends
BaseListCmd implements APIAuth
@Parameter(name = ApiConstants.SECRET_CODE, type = CommandType.STRING,
description = "Code that is provided by OAuth provider (Eg. google, github)
after successful login")
private String secretCode;
+ @Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID,
entityType = DomainResponse.class,
+ description = "Domain ID for domain-specific OAuth provider
lookup")
Review Comment:
```suggestion
description = "Domain ID for domain-specific OAuth provider
lookup", since = "4.23.0")
```
##########
plugins/user-authenticators/oauth2/src/main/java/org/apache/cloudstack/oauth2/api/command/VerifyOAuthCodeAndGetUserCmd.java:
##########
@@ -58,6 +59,14 @@ public class VerifyOAuthCodeAndGetUserCmd extends
BaseListCmd implements APIAuth
@Parameter(name = ApiConstants.SECRET_CODE, type = CommandType.STRING,
description = "Code that is provided by OAuth provider (Eg. google, github)
after successful login")
private String secretCode;
+ @Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID,
entityType = DomainResponse.class,
+ description = "Domain ID for domain-specific OAuth provider
lookup")
+ private Long domainId;
+
+ @Parameter(name = ApiConstants.DOMAIN, type = CommandType.STRING,
+ description = "Domain path for domain-specific OAuth provider
lookup")
Review Comment:
```suggestion
description = "Domain path for domain-specific OAuth provider
lookup", since = "4.23.0")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
