Damans227 commented on code in PR #12702:
URL: https://github.com/apache/cloudstack/pull/12702#discussion_r3001938976
##########
api/src/main/java/org/apache/cloudstack/auth/UserOAuth2Authenticator.java:
##########
@@ -44,6 +44,17 @@ public interface UserOAuth2Authenticator extends Adapter {
*/
String verifyCodeAndFetchEmail(String secretCode);
+ /**
+ * Verifies if the logged in user is valid for a specific domain
+ * @return returns true if its valid user
+ */
+ boolean verifyUser(String email, String secretCode, Long domainId);
+
+ /**
+ * Verifies the code provided by provider and fetches email for a specific
domain
+ * @return returns email
+ */
+ String verifyCodeAndFetchEmail(String secretCode, Long domainId);
Review Comment:
@sureshanaparti The domain-aware `verifyCodeAndFetchEmail(String secretCode,
Long domainId)` is an overload of the pre-existing
[verifyCodeAndFetchEmail(String
secretCode)](https://github.com/apache/cloudstack/blob/main/api/src/main/java/org/apache/cloudstack/auth/UserOAuth2Authenticator.java#L45).
If we rename only the new overload to `verifySecretCodeAndFetchEmail`, the two
methods would have inconsistent names. Should we rename both for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
