Copilot commented on code in PR #12967:
URL: https://github.com/apache/cloudstack/pull/12967#discussion_r3067880897
##########
server/conf/log4j-cloud.xml.in:
##########
@@ -68,7 +64,7 @@ under the License.
<Console name="CONSOLE" target="SYSTEM_OUT">
<ThresholdFilter level="OFF" onMatch="ACCEPT" onMismatch="DENY"/>
- <PatternLayout pattern="%-5p [%c{1.}] (%t:%x) %m%ex%n"/>
+ <PatternLayout pattern="%d{DEFAULT} %-5p [%c{1.}] (%t:%x) %m%ex%n"/>
Review Comment:
The PR description/title says this change adds timestamps to the *.err files
captured by systemd, but the shipped systemd units append stdout to *.out and
stderr to *.err. Since the Log4j2 Console appender here targets SYSTEM_OUT,
this pattern change will affect the *.out files, not *.err. Either update the
PR description/title to reflect *.out, or (if the goal really is *.err) switch
the Console appender target to SYSTEM_ERR and/or adjust the systemd unit
redirections accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
