Copilot commented on code in PR #12967:
URL: https://github.com/apache/cloudstack/pull/12967#discussion_r3084251020
##########
server/conf/log4j-cloud.xml.in:
##########
@@ -62,60 +66,84 @@ under the License.
<PatternLayout pattern="%-5p [%c{1.}] (%t:%x) %m%ex%n"/>
</Syslog>
+
<!-- ============================== -->
<!-- Append messages to the console -->
<!-- ============================== -->
+
<Console name="CONSOLE" target="SYSTEM_OUT">
- <ThresholdFilter level="OFF" onMatch="ACCEPT" onMismatch="DENY"/>
- <PatternLayout pattern="%-5p [%c{1.}] (%t:%x) %m%ex%n"/>
+ <ThresholdFilter level="ERROR" onMatch="DENY" onMismatch="ACCEPT"/>
+ <PatternLayout pattern="%d{DEFAULT} %-5p [%c{1.}] (%t:%x) %m%ex%n"/>
+ </Console>
+
+ <Console name="CONSOLE_ERR" target="SYSTEM_ERR">
+ <ThresholdFilter level="ERROR" onMatch="ACCEPT" onMismatch="DENY"/>
+ <PatternLayout pattern="%d{DEFAULT} %-5p [%c{1.}] (%t:%x) %m%ex%n"/>
Review Comment:
PR description/issue reference says this fixes #12887 (which also mentions
the Usage server), but this PR doesn’t update the Usage server Log4j2 config
(usage/conf/log4j-cloud_usage.xml.in) to emit ERRORs to SYSTEM_ERR with a
timestamped pattern. As-is, usage.err will likely remain untimestamped. Either
extend the change to the usage Log4j2 config or adjust the PR description/issue
linkage to clarify that Usage is out of scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
