sureshanaparti commented on code in PR #13050:
URL: https://github.com/apache/cloudstack/pull/13050#discussion_r3115381319
##########
plugins/storage/volume/flasharray/src/main/java/org/apache/cloudstack/storage/datastore/adapter/flasharray/FlashArrayAdapter.java:
##########
@@ -453,18 +453,46 @@ public void disconnect() {
@Override
public ProviderVolumeStorageStats getManagedStorageStats() {
FlashArrayPod pod = getVolumeNamespace(this.pod);
- // just in case
- if (pod == null || pod.getFootprint() == 0) {
+ if (pod == null) {
return null;
}
Long capacityBytes = pod.getQuotaLimit();
- Long usedBytes = pod.getQuotaLimit() - (pod.getQuotaLimit() -
pod.getFootprint());
+ if (capacityBytes == null || capacityBytes == 0) {
+ // Pod has no explicit quota set; report the array total physical
+ // capacity so the CloudStack allocator has a real ceiling to plan
+ // against rather than bailing out with a zero-capacity pool.
+ capacityBytes = getArrayTotalCapacity();
+ }
+ if (capacityBytes == null || capacityBytes == 0) {
+ return null;
+ }
+ Long usedBytes = pod.getFootprint();
+ if (usedBytes == null) {
+ usedBytes = 0L;
+ }
ProviderVolumeStorageStats stats = new ProviderVolumeStorageStats();
stats.setCapacityInBytes(capacityBytes);
stats.setActualUsedInBytes(usedBytes);
return stats;
}
+ private Long getArrayTotalCapacity() {
+ try {
+ FlashArrayList<Map<String, Object>> list =
GET("/arrays?space=true",
+ new TypeReference<FlashArrayList<Map<String, Object>>>() {
+ });
+ if (list != null && list.getItems() != null &&
!list.getItems().isEmpty()) {
Review Comment:
```suggestion
if (list != null && CollectionUtils.isNotEmpty(list.getItems()))
{
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
