genegr commented on PR #13050: URL: https://github.com/apache/cloudstack/pull/13050#issuecomment-4299993016
Pushed a new revision addressing the three review comments: - Use `CollectionUtils.isNotEmpty(list.getItems())` in `getArrayTotalCapacity()` (@sureshanaparti). - The `getArrayTotalCapacity()` warn log now includes the FlashArray URL and pod, and the stack trace was demoted to DEBUG so transient per-refresh warnings do not spam the log. - Cached the discovered array total capacity in a static URL-keyed map with a 5-minute TTL. The capacity of a physical FlashArray only changes when hardware is added or removed, so a several-minute TTL is safe and avoids an extra `/arrays?space=true` call on every storage stats refresh for every pool that has no pod quota set. Branch was also rebased onto current `apache/cloudstack:main`, which already contains the end-of-files/codespell fixes that the earlier pre-commit run flagged on unrelated files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
