genegr commented on PR #13049: URL: https://github.com/apache/cloudstack/pull/13049#issuecomment-4299280356
The two remaining check failures are unrelated to this PR: - **`pre-commit`** — the `end-of-file-fixer` reports `agent/conf/agent.properties` and `codespell` reports a typo (`calll` → `call`) in `plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtConvertInstanceCommandWrapper.java:110`. Neither of those files is touched by this PR. They were fixed later on `main` in commit `f820d0125d fix end of files and codespell errors`; a rebase onto current `main` should make the check pass without any change to this PR's content. - **`codecov/patch`** — the new branches in `FlashArrayAdapter` are not covered by new tests, which is typical for this adapter (the existing code in the file has no JUnit coverage either). With two approvals (@sureshanaparti, @DaanHoogland) and the remaining failures not attributable to this change, would it be OK to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
